Re: [PATCH 3/5] net: phy: Port MDIO bus miltiplexer framework from Linux kernel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 28, 2017 at 08:55:04PM -0800, Andrey Smirnov wrote:
> Port mdio-mux.c from Linux kernel to Barebox, to support adding
> dirvers that rely on that infrastructure/API.
> 
> Signed-off-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx>
> ---
>  drivers/net/phy/Kconfig    |   8 +++
>  drivers/net/phy/Makefile   |   2 +
>  drivers/net/phy/mdio-mux.c | 145 +++++++++++++++++++++++++++++++++++++++++++++
>  include/linux/mdio-mux.h   |  30 ++++++++++
>  4 files changed, 185 insertions(+)
>  create mode 100644 drivers/net/phy/mdio-mux.c
>  create mode 100644 include/linux/mdio-mux.h
> 
> diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
> index ea2e06265..f423d9ba3 100644
> --- a/drivers/net/phy/Kconfig
> +++ b/drivers/net/phy/Kconfig
> @@ -66,6 +66,14 @@ config MDIO_GPIO
>  	---help---
>  	  Supports GPIO lib-based MDIO busses.
>  
> +config MDIO_BUS_MUX
> +       	bool

Indentation gone wrong here.

> +	help
> +	  This module provides a driver framework for MDIO bus
> +	  multiplexers which connect one of several child MDIO busses
> +	  to a parent bus.  Switching between child busses is done by
> +	  device specific drivers.
> +

...

> +	for_each_available_child_of_node(mux_node, child_bus_node) {
> +		int v;
> +
> +		r = of_property_read_u32(child_bus_node, "reg", &v);
> +		if (r) {
> +			dev_err(dev,
> +				"Error: Failed to find reg for child %pOF\n",
> +				child_bus_node);
> +			continue;
> +		}
> +
> +		/*
> +		  FIXME:
> +		 */

What do you have to fix here?

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux