Re: [PATCH] readline_simple: use len instead of CONFIG_CBSIZE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 16, 2017 at 11:58:14PM -0500, Gaël PORTAY wrote:
> It is safier to use the length given in parameter instead of using the
> preprocessor CONFIG_CBSIZE value.
> 
> Signed-off-by: Gaël PORTAY <gael.portay@xxxxxxxxxxxxxxxxxxxx>
> ---

Applied, thanks

Sascha

>  lib/readline_simple.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/readline_simple.c b/lib/readline_simple.c
> index 80e075bc5..fcdbca41a 100644
> --- a/lib/readline_simple.c
> +++ b/lib/readline_simple.c
> @@ -100,7 +100,7 @@ int readline (const char *prompt, char *line, int len)
>  			/*
>  			 * Must be a normal character then
>  			 */
> -			if (n < CONFIG_CBSIZE-2) {
> +			if (n < len-2) {
>  				if (c == '\t') {	/* expand TABs		*/
>  					puts (tab_seq+(col&07));
>  					col += 8 - (col&07);
> -- 
> 2.15.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/barebox

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox




[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux