In fb_open() when fb_create_screen() fails then sc contains an
error pointer which is then freed in the failure path. Fix this.
Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
---
lib/gui/graphic_utils.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/lib/gui/graphic_utils.c b/lib/gui/graphic_utils.c
index 7d238e9ff9..0bed932213 100644
--- a/lib/gui/graphic_utils.c
+++ b/lib/gui/graphic_utils.c
@@ -285,15 +285,13 @@ struct screen *fb_open(const char * fbdev)
sc = fb_create_screen(info);
if (IS_ERR(sc)) {
ret = PTR_ERR(sc);
- goto failed_create;
+ goto failed_screeninfo;
}
sc->fd = fd;
return sc;
-failed_create:
- free(sc);
failed_screeninfo:
close(fd);
--
2.11.0
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
