On Mon, Jul 24, 2017 at 9:01 AM, Sam Ravnborg <sam@xxxxxxxxxxxx> wrote: > Hi Andrey. > >> Also, note, that for a reason I haven't been able to track down yet, >> compiling Barebox + this patchset without support for FEC will cause >> upstream kernel (at least 4.12-rc1) to hang during boot while trying >> to access FEC's register file. I suspect clock initialization issue, >> but, as I said, I did not find that out conclusively. > Maybe you should include this explanation in the patch that > enables this option? > I seemed like a kernel problem, so there's no code in the patchset that reflects this "limitation", meaning FEC driver is not automatically enabled if i.MX7 SabreSD is selected, so I don't know if there's a better place to put this note. >> >> Anyway, as usual, any feedback is wellcome. > > I have browsed the patches, and provided a little feedback. > Apart form this the series looks good to me. > > But then for most parts I am not intiminate with the > code so do not assume too much based on this. > Regardless, it was still useful feedback. Thanks! Andrey Smirnov _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
