On Mon, Jul 10, 2017 at 05:42:37PM +0200, Lucas Stach wrote: > Am Montag, den 10.07.2017, 17:27 +0200 schrieb Sam Ravnborg: > > Hi Lucas > > > > > index 000000000000..b1608dd9c730 > > > --- /dev/null > > > +++ b/arch/arm/boards/phytec-phycore-imx7/flash-header-phytec-phycore-imx7.imxcfg > > > @@ -0,0 +1,76 @@ > > > +/* > > > + * Copyright (C) 2016 NXP Semiconductors > > > + * > > > + * SPDX-License-Identifier: GPL-2.0 > > > + * > > > + * Refer docs/README.imxmage for more details about how-to configure > > > + * and create imximage boot image > > > + * > > > + * The syntax is taken as close as possible with the kwbimage > > > + */ > > > + > > > +soc imx7 > > > +loadaddr 0x80000000 > > > +dcdofs 0x400 > > > + > > > +wm 32 0x30340004 0x4F400005 > > > +/* Clear then set bit30 to ensure exit from DDR retention */ > > > +wm 32 0x30360388 0x40000000 > > > +wm 32 0x30360384 0x40000000 > > > + > > > +wm 32 0x30391000 0x00000002 > > > +wm 32 0x307a0000 0x01040001 > > > > > > Uwe posted a patch the other day to replace all these > > constants with defines across the tree. > > Looks like a step backward to introduce a new file where this approach is not used. > > Uwes patch replaces raw values in the i.MX6 files (where we have defines > for the registers). This is a new i.MX7 board, where no such defines > exists for now. OK, I had missed that "little" detail. > > I'm not saying that we shouldn't try to do the same thing for i.MX7, but > it is considerably more work than for MX6. Nice janitorial task for someone. Sam _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
