Re: [PATCH v1 3/3] regulator: pfuze: provide power over standby handler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 06.07.2017 um 16:12 schrieb Lucas Stach:
> Am Donnerstag, den 06.07.2017, 16:00 +0200 schrieb Oleksij Rempel:
>> This patch is providing an optional power off handler
>> which will configure standby state of the PMIC to disable all power lines.
>>
>> In my power consumption test on RIoTBoard, I got the following results:
>> power off without this patch:   320 mA
>> power off with this patch:      2   mA
>> suspend to ram:                 40  mA
> 
> You probably haven't measured suspend to ram with barebox, right? ;)

Oops... yeas :)

>>
>> Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
>> ---
>>  drivers/regulator/pfuze.c | 87 +++++++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 87 insertions(+)
>>
>> diff --git a/drivers/regulator/pfuze.c b/drivers/regulator/pfuze.c
>> index 2a5fb715ce..94fa03ff15 100644
>> --- a/drivers/regulator/pfuze.c
>> +++ b/drivers/regulator/pfuze.c
>> @@ -26,10 +26,53 @@
>>  
>>  #include <i2c/i2c.h>
>>  
>> +#include <poweroff.h>
>> +#include <mach/imx6.h>
>> +
> This introduces a build dependency of the PFUZE driver to the i.MX6
> architecture. While I think this is fine, as it keeps things
> straight-forward and the PFUZE is unlikely to be used on other SoCs,
> this needs at least a "depends on ARCH_IMX6" in the Kconfig entry.

Ok.
-- 
Regards,
Oleksij

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox

[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux