On Thu, Jul 06, 2017 at 10:49:41AM +0200, Lucas Stach wrote: > Am Mittwoch, den 05.07.2017, 21:23 +0200 schrieb Uwe Kleine-König: > > This makes the imxcfg files more readable and also makes it possible to > > share more assignments between machines that just differ by the used > > SoC. (Though I have to admit that in the cases converted here it just > > more easily allows to see that the RAM config differs more than probably > > necessary.) > > > > This change is intended to have no effect on the built artifacts. > > Does the "intended" in the above sentence mean you didn't validate that > the the generated flash headers are equal before and after the change in > any way? As much as I like the patch otherwise, this sounds scary. I verified it for some of them. I created a .config that enables all affected machine, but not for all of them a corresponding .dcd was generated. The one that existed then however didn't change with my patch. $ grep HIPER .config CONFIG_MACH_ELTEC_HIPERCAM=y $ armmake ... $ find -name \*.dcd | sort ./arch/arm/boards/cm-fx6/flash-header-mx6-cm-fx6.dcd ./arch/arm/boards/dfi-fs700-m60/flash-header-fs700-m60-6q-micron.dcd ./arch/arm/boards/dfi-fs700-m60/flash-header-fs700-m60-6q-nanya.dcd ./arch/arm/boards/dfi-fs700-m60/flash-header-fs700-m60-6s.dcd ./arch/arm/boards/embedsky-e9/flash-header-e9.dcd ./arch/arm/boards/embest-riotboard/flash-header-embest-riotboard.dcd ./arch/arm/boards/freescale-mx6-sabrelite/flash-header-mx6-sabrelite.dcd ./arch/arm/boards/freescale-mx6-sabresd/flash-header-mx6-sabresd.dcd ./arch/arm/boards/gk802/flash-header.dcd ./arch/arm/boards/technexion-pico-hobbit/flash-header-imx6ul-pico-hobbit-256.dcd ./arch/arm/boards/technexion-pico-hobbit/flash-header-imx6ul-pico-hobbit-512.dcd ./arch/arm/boards/technexion-wandboard/flash-header-technexion-wandboard.dcd ./arch/arm/boards/tqma6x/flash-header-tqma6dl.dcd ./arch/arm/boards/tqma6x/flash-header-tqma6q.dcd ./arch/arm/boards/udoo/flash-header-mx6-udoo.dcd ./arch/arm/boards/variscite-mx6/flash-header-variscite.dcd missing (and so unchecked) are: flash-header-eltec-hipercam.imxcfg karo-tx6x/* phytec-som-imx6/* zii-imx6q-rdu2/* even though: $ grep -E 'HIPER|TX6|_SOM|RDU2' .config CONFIG_MACH_PHYTEC_SOM_IMX6=y CONFIG_MACH_ELTEC_HIPERCAM=y CONFIG_MACH_TX6X=y CONFIG_MACH_ZII_RDU2=y Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
