Am Freitag, den 30.06.2017, 14:43 +0300 schrieb Andrey Gusakov:
> Also optimize DPCD writes
The word "also" in a commit message is a pretty strong hint that this
should be in a separate patch. The message of this commit should explain
what the fix for the AUXDATA access is without me needing to read the
code.
Regards,
Lucas
> ---
> drivers/video/tc358767.c | 28 +++++++++++++++-------------
> 1 file changed, 15 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/video/tc358767.c b/drivers/video/tc358767.c
> index d2c94c616..1541b18c9 100644
> --- a/drivers/video/tc358767.c
> +++ b/drivers/video/tc358767.c
> @@ -35,6 +35,7 @@
> #include <asm-generic/div64.h>
>
> #define DP_LINK_BW_SET 0x100
> +#define DP_ENHANCED_FRAME_EN (1 << 7)
> #define DP_TRAINING_PATTERN_SET 0x102
> #define TRAINING_LANE0_SET 0x103
>
> @@ -389,7 +390,7 @@ static int tc_aux_write(struct tc_data *tc, int reg, char *data, int size)
> i++;
> if (((i % 4) == 0) ||
> (i == size)) {
> - tc_write(DP0_AUXWDATA(i >> 2), tmp);
> + tc_write(DP0_AUXWDATA((i - 1) >> 2), tmp);
> tmp = 0;
> }
> }
> @@ -477,7 +478,7 @@ static int tc_aux_i2c_write(struct tc_data *tc, struct i2c_msg *msg)
> i++;
> if (((i % 4) == 0) ||
> (i == msg->len)) {
> - tc_write(DP0_AUXWDATA(i >> 2), tmp);
> + tc_write(DP0_AUXWDATA((i - 1) >> 2), tmp);
> tmp = 0;
> }
> }
> @@ -903,7 +904,7 @@ static int tc_main_link_setup(struct tc_data *tc)
> bool ready;
> u32 value;
> int ret;
> - u8 tmp[8];
> + u8 tmp[16];
>
> /* display mode should be set at this point */
> if (!tc->mode)
> @@ -1004,21 +1005,22 @@ static int tc_main_link_setup(struct tc_data *tc)
> /* LANE_COUNT_SET */
> tmp[1] = tc->link.lanes;
> if (tc->link.enhanced)
> - tmp[1] |= (1 << 7);
> - ret = tc_aux_write(tc, DP_LINK_BW_SET, tmp, 2);
> - if (ret)
> - goto err_dpcd_write;
> + tmp[1] |= DP_ENHANCED_FRAME_EN;
>
> - /* TRAINING_LANE0_SET .. TRAINING_LANE3_SET */
> - tmp[0] = 0x00;
> - tmp[1] = 0x00;
> + /* TRAINING_PATTERN_SET */
> tmp[2] = 0x00;
> + /* TRAINING_LANE0_SET .. TRAINING_LANE3_SET */
> tmp[3] = 0x00;
> + tmp[4] = 0x00;
> + tmp[5] = 0x00;
> + tmp[6] = 0x00;
> /* DOWNSPREAD_CTRL */
> - tmp[4] = tc->link.spread ? DP_SPREAD_AMP_0_5 : 0x00;
> + tmp[7] = tc->link.spread ? DP_SPREAD_AMP_0_5 : 0x00;
> /* MAIN_LINK_CHANNEL_CODING_SET */
> - tmp[5] = tc->link.coding8b10b ? DP_SET_ANSI_8B10B : 0x00;
> - ret = tc_aux_write(tc, TRAINING_LANE0_SET, tmp, 6);
> + tmp[8] = tc->link.coding8b10b ? DP_SET_ANSI_8B10B : 0x00;
> +
> + /* DP_LINK_BW_SET .. MAIN_LINK_CHANNEL_CODING_SET */
> + ret = tc_aux_write(tc, DP_LINK_BW_SET, tmp, 9);
> if (ret)
> goto err_dpcd_write;
>
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
