Hi Aleksander, On Thu, Jun 15, 2017 at 01:14:04PM +0200, Aleksander Morgado wrote: > Hey Sascha, > > I went through the RFC916 and ended up preparing a set of fixes and improvements for the RATP logic in barebox. > Let me know what you think. As far as I can say the patches look good. It's quite a while since I last looked at the RATP code, so I can't really judge. To which extent are the patches tested? Have you explicitly tested for the corner cases you fix in each patch? You probably have tested against your new library. Have you also tested against the python implementation? Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
