Re: [PATCH 4/4] usb-nop-xceiv: Add support for 'reset-gpios' binding

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 22, 2017 at 11:55 PM, Nikita Yushchenko
<nikita.yoush@xxxxxxxxxxxxxxxxxx> wrote:
>> +
>> +     if (gpio_is_valid(nopphy->reset)) {
>> +             /*
>> +              * Let's wait for 100 ms before deasserting reset line
>> +              */
>> +             mdelay(100);
>> +             gpio_direction_output(nopphy->reset, 0);
>> +     }
>
> Why not gpio_set_value() here?  Direction is already configured at this
> stage.

No reason, really. I'll fix it in v2.

Thanks,
Andrey Smirnov

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux