Hi Sam, On Sat, Apr 15, 2017 at 10:53:25AM +0200, Sam Ravnborg wrote: > > + if (memcmp(bucket->buf, buf, len)) > > + goto refresh; > > + > > + return 0; > > + > > +refresh: > > + ret = bucket->write(bucket, buf, len); > > In the code above we check needs_refresh and len. > But needs_refresh is never set back to 0 so it looks like we will refresh it too often. > The same with the len argument. You are right, I just sent a patch. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
