Hi Sascha.
Nitpick mode...
> --- a/lib/strtox.c
> +++ b/lib/strtox.c
> @@ -65,3 +65,11 @@ unsigned long long simple_strtoull (const char *cp, char **endp, unsigned int ba
> return result;
> }
> EXPORT_SYMBOL(simple_strtoull);
> +
> +long long simple_strtoll(const char *cp,char **endp,unsigned int base)
> +{
> + if(*cp=='-')
It hurts my eyes to see the missing space between if and "(".
simple_strtol() suffer from the same issue, but in the rest of the file
there is a space between if and "("
And on top I did not see simple_strtoull() used in the patch series.
But then I may have missed it as I just skimmed the patches.
Everything else I saw looked good.
Sam
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
