Re: [PATCH] ARM: zynq7000: make PS_CLK Kconfigurable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi ALexander,

On Sun, Mar 12, 2017 at 09:27:00PM +0100, Alexander Kurz wrote:
> The main clock source on Zynq-7000 based boards (PS_CLK) is not uniform
> for all boards, while typical boards are clocked with 33.3MHz, the
> Z-7010 based Digilent Zybo board is clocked with 50MHz.
> Since barebox is not yet OF aware for Zynq, make PS_CLK board dependent
> via Kconfig.

We shouldn't encode differences between boards in Kconfig.

One way around it would be to add platform_data to the clk device and
call zynq_init() (with an additional freq argument) from the board code rather
than directly from an initcall.
Creating a small zynq_set_ps_clk() which sets the clock and is to
be called by the board before the clock driver is initialized would be
simpler but also work.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux