Re: [PATCH 3/3] arm: dts: Added ocotp support for i.MX6UL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





Am 30.11.2016 um 17:38 schrieb Andrey Smirnov:
On Wed, Nov 30, 2016 at 3:10 AM, Daniel Schultz <d.schultz@xxxxxxxxx> wrote:
Ocotp is available for the iMX6(q|sx|sl) SoCs. This patch will extend the
iMX6ul DT from the mainline kernel to support the ocotp driver on the
iMX6ul SoC.

Signed-off-by: Daniel Schultz <d.schultz@xxxxxxxxx>
---
  arch/arm/dts/imx6ul-phytec-phycore-som.dts |  1 +
  arch/arm/dts/imx6ul.dtsi                   | 20 ++++++++++++++++++++
  2 files changed, 21 insertions(+)
  create mode 100644 arch/arm/dts/imx6ul.dtsi

diff --git a/arch/arm/dts/imx6ul-phytec-phycore-som.dts b/arch/arm/dts/imx6ul-phytec-phycore-som.dts
index be4556a..285ea62 100644
--- a/arch/arm/dts/imx6ul-phytec-phycore-som.dts
+++ b/arch/arm/dts/imx6ul-phytec-phycore-som.dts
@@ -13,6 +13,7 @@
  /dts-v1/;

  #include <arm/imx6ul.dtsi>
+#include "imx6ul.dtsi"

  / {
         model = "Phytec phyCORE-i.MX6 Ultra Lite SOM";
diff --git a/arch/arm/dts/imx6ul.dtsi b/arch/arm/dts/imx6ul.dtsi
new file mode 100644
index 0000000..2e02d27
--- /dev/null
+++ b/arch/arm/dts/imx6ul.dtsi
@@ -0,0 +1,20 @@
+/*
+ * Copyright (C) 2016 PHYTEC Messtechnik GmbH
+ * Author: Daniel Schultz <d.schultz@xxxxxxxxx>
+ *
+ * The code contained herein is licensed under the GNU General Public
+ * License. You may obtain a copy of the GNU General Public License
+ * Version 2 or later at the following locations:
+ *
+ * http://www.opensource.org/licenses/gpl-license.html
+ * http://www.gnu.org/copyleft/gpl.html
+ */
+
+&aips2 {
+       ocotp: ocotp-ctrl@21bc000 {
+               compatible = "fsl,imx6ul-ocotp";
+               reg = <0x021bc000 0x4000>;
+               clocks = <&clks IMX6UL_CLK_OCOTP>;

Just as my two cents, I'd say that all of the above (that is
instantiation of OCOT on AIPS2) should go via Linux kernel and trickle
down via syncing with its .dts tree (<arm/imx6ul.dtsi> in particular).
At least that's what I had to do for OCOTP in Vybrid. Although your
case might be more complicated since there are no bindings for
"fsl,imx6ul-ocotp" upstream, so take this with a grain of salt

Hi Andrey,

thanks, that's way better. I have sent a patch to the mainline kernel with this change. Sascha Hauer got a notification, so when it apply he can remove the patch.

--
Mit freundlichen Grüßen,
With best regards,
  Daniel Schultz

Cheers,
Andrey


_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox




[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux