Don't mask out the remapping flag before checking the register offset, otherwise none of the switch statements will ever match. Fixes: ff6a64d42ffc (e1000: Consolidate register offset fixups) Signed-off-by: Lucas Stach <l.stach@xxxxxxxxxxxxxx> --- v2: don't break it the other way around --- drivers/net/e1000/regio.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/e1000/regio.c b/drivers/net/e1000/regio.c index b2e9d7b6a7df..1610d5851f05 100644 --- a/drivers/net/e1000/regio.c +++ b/drivers/net/e1000/regio.c @@ -5,8 +5,6 @@ static uint32_t e1000_true_offset(struct e1000_hw *hw, uint32_t reg) { if (reg & E1000_MIGHT_BE_REMAPPED) { - reg &= ~E1000_MIGHT_BE_REMAPPED; - if (hw->mac_type == e1000_igb) { switch (reg) { case E1000_EEWR: @@ -19,7 +17,8 @@ static uint32_t e1000_true_offset(struct e1000_hw *hw, uint32_t reg) reg = E1000_I210_EEMNGCTL; break; } - }; + } + reg &= ~E1000_MIGHT_BE_REMAPPED; } return reg; -- 2.10.1 _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox