Hi Giorgio,
Looks good mostly. Patch 1/2 is fine, some small remarks for this one.
On Fri, Sep 23, 2016 at 11:07:39AM +0200, Giorgio Dal Molin wrote:
> Signed-off-by: Giorgio Dal Molin <iw3gtf@xxxxxxxx>
> ---
> commands/ubi.c | 71 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 71 insertions(+)
>
> diff --git a/commands/ubi.c b/commands/ubi.c
> index 7c55195..3c5729e 100644
> --- a/commands/ubi.c
> +++ b/commands/ubi.c
> @@ -328,3 +328,74 @@ BAREBOX_CMD_START(ubirmvol)
> BAREBOX_CMD_GROUP(CMD_GRP_PART)
> BAREBOX_CMD_HELP(cmd_ubirmvol_help)
> BAREBOX_CMD_END
> +
> + ret = ioctl(fd, UBI_IOCGETUBINUM, &ubi_num);
> + if (ret) {
> + perror("failed to get the ubi num");
> + return COMMAND_ERROR_USAGE;
> + }
> + close(fd);
> +
> + for(i=2, j=0; i<argc; ++j, i+=2) {
Please add a space pn both sides of binary operators.
> + req.ents[j].vol_id = get_vol_id(ubi_num, argv[i]);
> + if(req.ents[j].vol_id < 0) {
> + printf("'%s' is not a volume name.\n", argv[i]);
It is a volume name, but not a valid one. Better something like
printf("Volume '%s' does not exist on %s\n", argv[i], argv[1]);
?
> + return COMMAND_ERROR_USAGE;
> + }
> + strncpy(req.ents[j].name, argv[i+1], UBI_MAX_VOLUME_NAME);
> + req.ents[j].name_len = strlen(req.ents[j].name);
> + }
> +
> + ret = ubi_api_rename_volumes(ubi_num, &req);
> + if (ret)
> + perror("failed to rename.");
perror("failed to rename: %s", strerror(-ret));
It's always nice to print the error reason if we can.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
