Re: [PATCH 1/3] nand: denali: use correct interrupts in read_page

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 22, 2016 at 04:46:37PM +0200, Steffen Trumtrar wrote:
> The interrupt mask is incorrect in case of HW error correction.
> The driver will time out waiting for the wrong interrupts.
> 
> Signed-off-by: Steffen Trumtrar <s.trumtrar@xxxxxxxxxxxxxx>
> ---
>  drivers/mtd/nand/nand_denali.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/drivers/mtd/nand/nand_denali.c b/drivers/mtd/nand/nand_denali.c
> index bf9a05d85264..ceb5a8b87e42 100644
> --- a/drivers/mtd/nand/nand_denali.c
> +++ b/drivers/mtd/nand/nand_denali.c
> @@ -1102,8 +1102,9 @@ static int denali_read_page(struct mtd_info *mtd, struct nand_chip *chip,
>  	size_t size = denali->mtd.writesize + denali->mtd.oobsize;
>  
>  	uint32_t irq_status;
> -	uint32_t irq_mask = INTR_STATUS__ECC_TRANSACTION_DONE |
> -			    INTR_STATUS__ECC_ERR;
> +	uint32_t irq_mask = denali->have_hw_ecc_fixup ?
> +		(INTR_STATUS__DMA_CMD_COMP) :
> +		(INTR_STATUS__ECC_TRANSACTION_DONE | INTR_STATUS__ECC_ERR);
>  	bool check_erased_page = false;
>  
>  	if (page != denali->page) {
> -- 
> 2.9.3
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux