Re: [PATCH] Do not rm the path from pbl-y target

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jun 25, 2016 at 11:35:59AM +0800, zzs213@xxxxxxx wrote:
> From: 张忠山 <zzs213@xxxxxxx>
> 
> Whan add some obj in a subdir to lwl-y or pbl-y, like this:
> 
>     lwl-y += subdir/test.o other.o
> 
> the make process failed:
> 
>     make[2]: *** No rule to make target 'arch/arm/boards/boardname/test.o', \
>         needed by 'arch/arm/boards/boardname/built-in-pbl.o'.  Stop.
> 
> Note, there are not the part "subdir" in the path of the test.o.
> 
> this patch fix this
> 
> Signed-off-by: 张忠山 <zzs213@xxxxxxx>
> ---
>  scripts/Makefile.lib | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index 27365d8..73b9c57 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -39,10 +39,9 @@ endif
>  obj-y		+= $(obj-pbl-y)
>  pbl-y		+= $(obj-pbl-y)
>  
> -# for non dirs add pbl- prefix to the target
> -# so we recompile the source with custom flags and custom quiet
> -__pbl-y		:= $(notdir $(pbl-y))
> -pbl-y		:= $(patsubst %.o,pbl-%.o,$(__pbl-y))
> +# add pbl- prefix to the target
> +pbl-y		:= $(shell echo $(pbl-y) | sed -e 's%\(\([^ \t]\+/\)*\)\([^ \t]*.o\)%\2pbl-\3%g')
> +

I had to revert this one. The regular expression seems to be wrong. It
breaks omap3530_beagle_defconfig with:

make[2]: *** No rule to make target 'arch/arm/mach-omap/opbl-map3_clock.o', needed by 'arch/arm/mach-omap/built-in-pbl.o'.  Stop.
make[2]: *** Waiting for unfinished jobs....

Instead of pbl-omap3_clock.o it tries to generate opbl-map3_clock.o.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox




[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux