2016-06-07 13:00 GMT+02:00 Antony Pavlov <antonynpavlov@xxxxxxxxx>: > On Thu, 2 Jun 2016 10:06:58 +0200 > Raphael Poggi <poggi.raph@xxxxxxxxx> wrote: > >> Add qemu virt board which emulates arm64 board. >> >> Signed-off-by: Raphael Poggi <poggi.raph@xxxxxxxxx> >> --- >> arch/arm/Kconfig | 9 ++++ >> arch/arm/boards/Makefile | 1 + >> arch/arm/boards/virt/Kconfig | 8 ++++ > > Can we use a more descriptive 'qemu-virt' name for this machine/board instead of 'virt'? Qemu virt machine support armv7 and armv8 cpu, maybe we can use the name "mach-qemu" for the machine and "qemu-virt64" for the board. With this approach we use a generic name for the machine (since qemu virt machine support armv7/armv8, we do not need to distinguish between arm/arm64), and made the distinction arm/arm64 only in board name. This also lets the possibility, for someone who wants to add support for qemu virt arm32 board, to not create another machine folder. What do you think about that ? Raphaël > >> arch/arm/boards/virt/Makefile | 1 + >> arch/arm/boards/virt/env/bin/_update | 36 ++++++++++++++++ >> arch/arm/boards/virt/env/bin/boot | 38 +++++++++++++++++ > > ... skipped ... > > -- > Best regards, > Antony Pavlov > > _______________________________________________ > barebox mailing list > barebox@xxxxxxxxxxxxxxxxxxx > http://lists.infradead.org/mailman/listinfo/barebox _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
