Re: [PATCH 2/3] usb: Add OHCI platform driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 25, 2016 at 09:13:25PM +0300, Alexander Shiyan wrote:
> Signed-off-by: Alexander Shiyan <shc_work@xxxxxxx>
> ---
>  drivers/usb/host/Kconfig         |  3 +++
>  drivers/usb/host/Makefile        |  1 +
>  drivers/usb/host/ohci-platform.c | 57 ++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 61 insertions(+)
>  create mode 100644 drivers/usb/host/ohci-platform.c
> 
> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> index 54eaf46..6ff4afc 100644
> --- a/drivers/usb/host/Kconfig
> +++ b/drivers/usb/host/Kconfig
> @@ -22,6 +22,9 @@ config USB_OHCI_AT91
>  	depends on ARCH_AT91
>  	bool "AT91 OHCI driver"
>  
> +config USB_OHCI_PLATFORM
> +	bool "Platform OHCI driver"
> +
>  endif
>  
>  config USB_XHCI
> diff --git a/drivers/usb/host/Makefile b/drivers/usb/host/Makefile
> index 0478d34..1b5319d 100644
> --- a/drivers/usb/host/Makefile
> +++ b/drivers/usb/host/Makefile
> @@ -3,5 +3,6 @@ obj-$(CONFIG_USB_EHCI_OMAP)	+= ehci-omap.o
>  obj-$(CONFIG_USB_EHCI_ATMEL)	+= ehci-atmel.o
>  obj-$(CONFIG_USB_OHCI)		+= ohci-hcd.o
>  obj-$(CONFIG_USB_OHCI_AT91)	+= ohci-at91.o
> +obj-$(CONFIG_USB_OHCI_PLATFORM)	+= ohci-platform.o
>  obj-$(CONFIG_USB_XHCI)		+= xhci-hcd.o xhci-hub.o
>  obj-$(CONFIG_USB_XHCI_PCI)	+= xhci-pci.o
> diff --git a/drivers/usb/host/ohci-platform.c b/drivers/usb/host/ohci-platform.c
> new file mode 100644
> index 0000000..4c97330
> --- /dev/null
> +++ b/drivers/usb/host/ohci-platform.c
> @@ -0,0 +1,57 @@
> +/*
> + * Copyright (C) 2014 Alexander Shiyan <shc_work@xxxxxxx>
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + */
> +
> +#include <common.h>
> +#include <driver.h>
> +#include <errno.h>
> +#include <init.h>
> +#include <io.h>
> +#include <linux/clk.h>
> +
> +struct ohci_platform_data {
> +	int (*probe)(struct device_d *, struct resource *);
> +};
> +
> +static struct platform_device_id ohci_platform_ids[] = {
> +	{ }
> +};
> +
> +static int ohci_platform_probe(struct device_d *dev)
> +{
> +	struct ohci_platform_data *data;
> +	struct resource *res;
> +	int ret;
> +
> +	ret = dev_get_drvdata(dev, (const void **)&data);
> +	if (ret)
> +		return ret;
> +
> +	res = dev_get_resource(dev, IORESOURCE_MEM, 0);
> +	if (IS_ERR(res))
> +		return PTR_ERR(res);
> +
> +	dev->priv = data;
> +
> +	if (data->probe) {
> +		ret = data->probe(dev, res);
> +		if (ret)
> +			return ret;
> +	}
> +
> +	add_generic_device_res("ohci", DEVICE_ID_SINGLE, res, 1, NULL);

We should get rid of this additional device along the way and instead
create a dedicated ohci_register() function which is directly called by
the different SoC specific drivers. See the ehci driver for a template
what I mean.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux