Hi Stefan,
On Tue, Mar 29, 2016 at 11:29:45AM +0200, Stefan Christ wrote:
> Hi Sascha,
>
> > @@ -147,6 +218,8 @@ int barebox_update(struct bbu_data *data)
> > if (!data->devicefile)
> > data->devicefile = handler->devicefile;
> >
> > + bbu_check_metadata(data);
> > +
> > ret = handler->handler(handler, data);
> > if (ret == -EINTR)
> > printf("update aborted\n");
>
> hmm. I think the code should be
>
> ret = bbu_check_metadata(data);
> if (ret)
> return ret;
>
> or something. Otherwise the verification of the compatible doesn't abort the
> update process. The function bbu_check_metadata returns -EINVAL if the
> compatible is wrong.
Indeed, fixed this.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
