> https://github.com/maximeh/buildroot/tree/master/board/calao/qil-a9260/patches/barebox > > It is reasonable to have as much author(s) information as possible. So your Sob will be > very usable if somebody who works with the patch. This patch has "From:" field and exactly the same "Signed-off-by:" field. So no new additional information Sob gives you here. The Sob indeed will give you simplification when you want to squash many-many commits by many-many authors and for god's sake you don't want to reclaim ownership of each commit! But again, does Barebox facing such cases? Does it really necessary to follow all linux-related work process rules? Just look at this: Signed-off-by: James Hogan <james.hogan@xxxxxxxxxx> Fixes: e9de688dac65 ("irqchip: mips-gic: Support local interrupts") Cc: Andrew Bresticker <abrestic@xxxxxxxxxxxx> Cc: Qais Yousef <qais.yousef@xxxxxxxxxx> Cc: Paul Burton <paul.burton@xxxxxxxxxx> Cc: Jason Cooper <jason@xxxxxxxxxxxxxx> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx> Cc: linux-mips@xxxxxxxxxxxxxx Reviewed-by: Andrew Bresticker <abrestic@xxxxxxxxxxxx> Patchwork: https://patchwork.linux-mips.org/patch/9081/ Signed-off-by: Ralf Baechle <ralf@xxxxxxxxxxxxxx> That's something! Because many people are invlolved. Linux is a huge machine. Barebox is not Linux. And just for comparsion, this is from Barebox: -------------------------- commit a6f73ec52f5c794938aa14b1264375228890f12c Author: Ulrich Ölmann <u.oelmann@xxxxxxxxxxxxxx> Date: Thu Feb 4 08:25:24 2016 +0100 docs: fix typos Signed-off-by: Ulrich Ölmann <u.oelmann@xxxxxxxxxxxxxx> Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> diff --git a/Documentation/devicetree/bindings/barebox/barebox,state.rst b/Documentation/devicetree/bindings/barebox/barebox,state.rst index d1b0627..d507657 100644 --- a/Documentation/devicetree/bindings/barebox/barebox,state.rst +++ b/Documentation/devicetree/bindings/barebox/barebox,state.rst @@ -43,7 +43,7 @@ Variable nodes These are subnodes of a state node each describing a single variable. The node name may end with ``@<ADDRESS>``, but the suffix is -sripped from the variable name. +stripped from the variable name. State variables have a type. Currenty supported types are: ``uint8``, ``uint32``, ``enum32``, ``mac`` address or ``string``. Variable length -------------------------- > Here is a poor example: patch without any comments at all, it's very difficult to trace origins > of this patch: > > https://github.com/openwrt/openwrt/blob/master/target/linux/ar71xx/patches-4.4/200-MIPS-ath79-fix-ar933x-wmac-reset.patch Indeed, plain patches lacks origins. 1) That's why everyone here uses "git send-email" so that "git am" will apply patch with proper "Author:" field. 2) In the case of openwrt patch, why do anyone needs the origins anyway? If this patch breaks something - fix with new one, if not - okay then. If you know that that patch was written by Some Person - what this will give you? _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox