Re: [PATCH 1/3] bootm: fix uImage crashes when no partition is given

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Montag, den 29.02.2016, 08:48 +0100 schrieb Sascha Hauer:
> On Fri, Feb 26, 2016 at 08:12:37PM +0100, Lucas Stach wrote:
> > From: Lucas Stach <l.stach@xxxxxxxxxxxxxx>
> > 
> > Before the conversion to use the partition string instead of a plain
> > integer the default was partition 0, now it's just a NULL pointer.
> > 
> > There are a lot of places where strtoul is called on the partition string
> > which crashes when encountering the NULL pointer. Instead of fixing all
> > those places, plug in a default partition string that matches the old
> > behavior by picking partition 0.
> 
> This was my first approach aswell, but I didn't like the static "0"
> string, so I came up with
> http://lists.infradead.org/pipermail/barebox/2016-February/026368.html
> 
Fix looks good.

Can you drop this one patch, but apply the other 2 from this series?

Regards,
Lucas

-- 
Pengutronix e.K.             | Lucas Stach                 |
Industrial Linux Solutions   | http://www.pengutronix.de/  |


_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux