On Wed, Dec 09, 2015 at 09:55:29PM +0000, Trent Piepho wrote: > The partition code registers one or two cdevs for each partition. The > 2nd one is used if the partition has a name. The block of code for > each cdev is duplicated twice, and the 2nd copy is missing the bit > that copies the partition uuid and the dos partition type to the cdev. > > Refactor the register cdev out to a new function that is called twice. > This way each cdev is done correctly. Nice. Besides of fixing a bug this makes intention of the code is much clearer. Thanks, applied. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox