Re: [RFC 0/2] add multiplexed I2C bus support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 18, 2015 at 04:00:02PM +0300, Antony Pavlov wrote:
> This patchseries adds multiplexed I2C bus support to barebox
> and a driver for pca954x bus multiplexer.
> 
> This series has the "RFC" status mostly because of these
> adapter numbering hack in drivers/i2c/i2c-mux.c:
> 
>     /* FIXME */
> //  priv->adap.nr = mux_dev->id;
>     priv->adap.nr = -1;
>     ret = i2c_add_numbered_adapter(&priv->adap);

What's wrong with -1 as adapter nr? Why do consider this a hack?

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux