On Wed, Nov 11, 2015 at 08:55:54PM +0100, Lucas Stach wrote:
> Printing 3 lines of output per CRTC if no modes are found (which
> may be just fine if no display is attached) is just a bit too much,
> especially on SoCs like i.MX6Q that carry 4 CRTCs.
> Failing to find modes is not a fatal error, so the error does not
> need to be propagated into a probe failure.
>
> Signed-off-by: Lucas Stach <dev@xxxxxxxxxx>
> ---
> drivers/video/imx-ipu-v3/ipufb.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/video/imx-ipu-v3/ipufb.c b/drivers/video/imx-ipu-v3/ipufb.c
> index a96883c..ea81270 100644
> --- a/drivers/video/imx-ipu-v3/ipufb.c
> +++ b/drivers/video/imx-ipu-v3/ipufb.c
> @@ -308,7 +308,7 @@ static int ipufb_probe(struct device_d *dev)
>
> node = of_graph_get_port_by_id(dev->parent->device_node, 2 + pdata->di);
> if (node && of_graph_port_is_available(node)) {
> - dev_info(fbi->dev, "register vpl for %s\n", dev->parent->device_node->full_name);
> + dev_dbg(fbi->dev, "register vpl for %s\n", dev->parent->device_node->full_name);
I recently already applied this hunk.
>
> fbi->vpl.node = dev->parent->device_node;
> ret = vpl_register(&fbi->vpl);
> @@ -330,8 +330,8 @@ static int ipufb_probe(struct device_d *dev)
>
> ret = vpl_ioctl(&fbi->vpl, 2 + fbi->dino, VPL_GET_VIDEOMODES, &info->modes);
> if (ret) {
> - dev_err(fbi->dev, "failed to get modes: %s\n", strerror(-ret));
> - return ret;
> + dev_dbg(fbi->dev, "failed to get modes: %s\n", strerror(-ret));
> + return 0;
> }
I looked at this one aswell and wondered if it would be better to just
register the framebuffer without modes. Trying to enable this
framebuffer results in:
imx-ipuv3-crtc imx-ipuv3-crtc0: No valid mode found
Which might be a better hint what actually went wrong with the
framebuffer.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
