Re: [PATCH] ARM: i.mx53: Add support for Digi ConnectCore ccwmx53 SOM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Jason,

there are several problems with this patch:

 - No Signed-off-by line
 - A i.MX machine should really use dt
 - The patch is line-wrapped which makes impossible to apply without
   handwork (unless git has improved accordingly since I looked at such
   a patch last time)
 - Use tabs for indention
 - There is no need for a ccwmx53.h if there is only a single #includer
 - I don't know how you created the patch, but it wasn't git
   format-patch which I'd recommend here

Best regards
Uwe


-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox




[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux