Re: [PATCH] fs: smhfs: Fix return value of truncate()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Nov 08, 2015 at 04:21:13PM -0800, Andrey Smirnov wrote:
> Returning -ENOSYS as a result of truncate() breaks ability to write to
> semihosting host's filesystem, so change the return value to 0. This
> shouldn't cause any problems since all of the funcionlaity of
> truncate() should is already handled by 'open' (via O_TRUNC) and
> 'write' (will automatically grow the file size when writing)
> automatically
> 
> Unfortunately this was missed in original commit that introduced
> semihosting
> 
> Signed-off-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx>

Applied, thanks

Sascha

> ---
>  fs/smhfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/smhfs.c b/fs/smhfs.c
> index a0df06c..f1b6d6b 100644
> --- a/fs/smhfs.c
> +++ b/fs/smhfs.c
> @@ -58,7 +58,7 @@ static int smhfs_truncate(struct device_d __always_unused *dev,
>  			  FILE __always_unused *f,
>  			  ulong __always_unused size)
>  {
> -	return -ENOSYS;
> +	return 0;
>  }
> 
>  static int smhfs_open(struct device_d __always_unused *dev,
> --
> 2.1.4
> 
> _______________________________________________
> barebox mailing list
> barebox@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux