Hi Antony, On Sun, Jul 12, 2015 at 01:07:12PM +0300, Antony Pavlov wrote: > --- > Sascha moved fbconsole registration to common fb code. > So we can drop this supefluous code. > --- > drivers/video/sdl.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) Squashed this into the fbconsole patch. Also I applied the patch I just sent to the list which adds a fb_create_screen function which creates a screen from a struct fb_info *. With this we get rid of the hardcoded opening of /dev/fb0. What's missing now is that fbc_set_active() should check the flags argument and actually disable the fbconsole and free the resources. Also I'm not sure if the framebuffer should be activated when the framebuffer console is activated. While this is convenient for the user we get into a reference counting problem. What if the framebuffer was activated before the fbconsole? Should we skip enabling the framebuffer in this case? When disabling the fbconsole then we must now if the fbconsole code activated the framebuffer and only then disable the framebuffer again. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
