Re: [RFC V2 1/3] common: move DDR_SPD to common/Kconfig

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



There may be an issue in the future. DDR_SPD selects the PPC Freescale
DDR driver support (my fault for this bad choice). If somebody was to
add and build a PPC machine with DDR support that is none of the
Freescale boards then the Freescale DDR driver will be selected too.

To be safe, something like that could be used:

diff --git a/arch/ppc/mach-mpc85xx/Makefile b/arch/ppc/mach-mpc85xx/Makefile
index 3e64617..a7453f7 100644
--- a/arch/ppc/mach-mpc85xx/Makefile
+++ b/arch/ppc/mach-mpc85xx/Makefile
@@ -9,5 +9,6 @@ obj-y                   += fsl_i2c.o
 obj-$(CONFIG_MP)       += mp.o
 obj-$(CONFIG_OFTREE)   += fdt.o
 obj-$(CONFIG_DRIVER_NET_GIANFAR) += eth-devices.o
-obj-$(CONFIG_DDR_SPD)  += ../ddr-8xxx/
+obj-$(CONFIG_FSL_DDR2) += ../ddr-8xxx/
+obj-$(CONFIG_FSL_DDR3) += ../ddr-8xxx/


On 24/06/2015 13:57, Alexander Smirnov wrote:
> This patch makes it possible to use ddr_spd-related
> routines in any arch not only in ppc.
> 
> Signed-off-by: Alexander Smirnov <alllecs@xxxxxxxxx>
> ---
>  arch/ppc/mach-mpc85xx/Kconfig | 4 ----
>  common/Kconfig                | 4 ++++
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/ppc/mach-mpc85xx/Kconfig b/arch/ppc/mach-mpc85xx/Kconfig
> index e29be9c..aa518b9 100644
> --- a/arch/ppc/mach-mpc85xx/Kconfig
> +++ b/arch/ppc/mach-mpc85xx/Kconfig
> @@ -81,10 +81,6 @@ config P1022
>  config MPC8544
>  	bool
>  
> -config DDR_SPD
> -	bool
> -	select CRC16
> -
>  config FSL_DDR2
>  	bool
>  
> diff --git a/common/Kconfig b/common/Kconfig
> index 925fe4b..91e4ef3 100644
> --- a/common/Kconfig
> +++ b/common/Kconfig
> @@ -941,3 +941,7 @@ endmenu
>  
>  config HAS_DEBUG_LL
>  	bool
> +
> +config DDR_SPD
> +	bool
> +	select CRC16
> 


_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux