Hi Sascha,
On Wednesday 24 June 2015 08:32:47 Sascha Hauer wrote:
> [...]
> > +void reset_source_set(enum reset_src_type st, enum f_scope scope)
> > +{
> > + if ((int)scope <= reset_source_scope)
> > + return; /* just ignore this setting */
> > +
> > + reset_source = (int)st;
> > + reset_source_scope = (int)scope;
> > + reset_source_update_global_info();
>
> This call is unnecessary. You can call globalvar_add_simple_enum()
> directly from the initcall.
It took me longer to understand your comment here... Yes, sure.
globalvar_add_simple_enum() do all the necessary things in background.
Thanks, will change it.
jbe
--
Pengutronix e.K. | Juergen Borleis |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
