> Please add a imx6_ namespace to this function. The calling code always > knows that it is running on imx6, so you can use IMX6_CCM_BASE_ADDR > directly rather than using soc##_. The function above is imx6 specific > anyway since only this SoC has the gate registers on 0x68..0x80. What about i.MX51? As far as I can tell it is the same as i.MX6 in this aspect. This function wouldn't have any consumers on i.MX51 architecture, of course, but shouldn't this function have a SoC variant agnostic name, just for the sake of genericity? > > Sascha > > -- > Pengutronix e.K. | | > Industrial Linux Solutions | http://www.pengutronix.de/ | > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox