On Wed, Apr 01, 2015 at 06:14:15PM +0200, Marc Kleine-Budde wrote: > + > +static inline const struct habv4_rvt *habv4_get_rvt(void) > +{ > + if (__rvt) > + return __rvt; > + > + if (IS_ENABLED(CONFIG_ARCH_IMX28)) > + __rvt = (void *)HABV4_RVT_IMX28; > + else if (IS_ENABLED(CONFIG_ARCH_IMX6)) > + __rvt = (void *)HABV4_RVT_IMX6; Better use cpu_is_mx28 and cpu_is_mx6 here. You should probably provide a static inline wrapper for habv4_get_status(). Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox