Re: [PATCH] net: ping: return an error exit code when connection fails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Il 2015-03-16 16:02 Mirko Damiani ha scritto:
Hi,
ping command does not always returns 1 as exit code when connection to
host fails.
In particular it returns the exit code of the previous run.
This patch fixes this issue.


Sorry, the same patch with proper tabulation characters.


Signed-off-by: Mirko Damiani <mirko@xxxxxxxxxxx>
---
 net/ping.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/net/ping.c b/net/ping.c
index 2349f4b..4eb77cb 100644
--- a/net/ping.c
+++ b/net/ping.c
@@ -67,6 +67,9 @@ static int do_ping(int argc, char *argv[])
 		return 1;
 	}

+	ping_state = PING_STATE_INIT;
+	ping_sequence_number = 0;
+
 	ping_con = net_icmp_new(net_ping_ip, ping_handler, NULL);
 	if (IS_ERR(ping_con)) {
 		ret = PTR_ERR(ping_con);
@@ -78,9 +81,6 @@ static int do_ping(int argc, char *argv[])
 	if (ret)
 		goto out_unreg;

-	ping_state = PING_STATE_INIT;
-	ping_sequence_number = 0;
-
 	while (ping_state == PING_STATE_INIT) {
 		if (ctrlc()) {
 			ret = -EINTR;
--
1.9.1

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox




[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux