On Fri, Dec 26, 2014 at 10:51:43AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote: > HI, > > since the switch to ERR_PTR & co > > for dev_get_resource_by_name & others the at91 is broken > > as on barebox we use a 1:1 mapping and the check of the IS_ERR is > ((unsigned long)-MAX_ERRNO) > > but on at91 the PIT and so on are at 0xfffffd30 so on always seen as > an error Damn :( Since dev_get_resource_by_name returns a struct resource pointer it shouldn't be broken, right? What's broken should be: dev_get_mem_region_by_name dev_request_mem_region_by_name dev_request_mem_region > > so can we revert the commit on > > ommit 92cc1b1f9e3363046583962859a3a8c054f4b94d Since these commits touch so many files I'm not sure we can simply revert these commits. All drivers that check for IS_ERR() from the above functions that were introduced after the commits to revert would have to be changed aswell. The functions should still work, but the error check with IS_ERR() does not, right? So as a stop gap solution we could drop the error check from the affected drivers and as the next step change the prototype of the affected functions to something like: int dev_request_mem_region(struct device_d *dev, int num, void __iomem **base); Which drivers are affected anyway? Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
