On Fri, Sep 12, 2014 at 05:18:18PM +0200, Sebastian Hesselbarth wrote: > On 09/12/2014 12:07 PM, Sascha Hauer wrote: > >- Remove OFDEVICE dependency from PINCTRL. It won't do > > much then, so add a comment to Kconfig when PINCTRL is > > selected without OFDEVICE > >- Let Architectures only select PINCTRL instead of the > > particular driver. Change the drivers to 'default y if $SOC' > > to make sure the drivers are still compiled if the corresponding > > SoC is selected > > > >This fixes Kconfig warnings like: > > > >warning: (PINCTRL_ARMADA_370 && PINCTRL_ARMADA_XP && PINCTRL_DOVE && PINCTRL_KIRKWOOD) selects PINCTRL which has unmet direct dependencies (OFDEVICE) > > > >Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > >--- > > arch/arm/mach-mvebu/Kconfig | 8 ++++---- > > arch/arm/mach-tegra/Kconfig | 6 +++--- > > drivers/pinctrl/Kconfig | 24 ++++++++++++++++-------- > > drivers/pinctrl/mvebu/Kconfig | 8 ++++---- > > drivers/pinctrl/pinctrl-rockchip.c | 3 +++ > > drivers/pinctrl/pinctrl.c | 6 ++++++ > > 6 files changed, 36 insertions(+), 19 deletions(-) > > For mvebu, you could also move 'select PINCTRL' to config MACH_MVEBU. > I guess the same is also true for Tegra? Yes, every Tegra board has pinctrl, so I moved the select statements to ARCH_MVEBU / ARCH_TEGRA > > But that is just a nit, so > > Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth@xxxxxxxxx> Thanks Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
