On Wed, Jul 02, 2014 at 08:45:28AM +0200, Herve Codina wrote:
> Hi,
>
> I haven't got any news about this patch.
> Has it been reviewed ?
>
> I hope it was not lost in the flow of other patches.
> If so, i can resend it.
Sorry, I have seen it but then forgot to write an answer.
> > diff --git a/include/password.h b/include/password.h
> > index 0dd1054..9d84685 100644
> > --- a/include/password.h
> > +++ b/include/password.h
> > @@ -18,8 +18,14 @@
> > #ifndef __PASSWORD_H__
> > #define __PASSWORD_H__
> >
> > -#define PASSWD_FILE "/env/etc/passwd"
> > -#define PASSWD_DIR "/env/etc/"
> > +#ifdef CONFIG_PASSWORD_DIR
> > +#define PASSWD_DIR CONFIG_PASSWORD_DIR
> > +#else
> > +#define PASSWD_DIR "/env/etc"
> > +#endif
> > +
> > +#define PASSWD_FILE PASSWD_DIR"/passwd"
I don't like this ifdeffery. If you want to have this configurable
please make a
static char *passwd_file = "/env/etc/passwd"
int set_passwd_file(const char *file)
{
passwd_file = file;
}
And call it from your board code.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
