On Thu, Jun 26, 2014 at 10:49:15AM +0200, Holger Schurig wrote: > ... and it's defined only when CONFIG_OFTREE_MEM_GENERIC is on. > > Signed-off-by: Holger Schurig <holgerschurig@xxxxxxxxx> > --- > drivers/of/base.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/of/base.c b/drivers/of/base.c > index c440a69..818d76e 100644 > --- a/drivers/of/base.c > +++ b/drivers/of/base.c > @@ -1697,6 +1697,7 @@ int of_set_property(struct device_node *np, const char *name, const void *val, i > return 0; > } > > +#ifdef CONFIG_OFTREE_MEM_GENERIC > int of_add_memory(struct device_node *node, bool dump) > { > const char *device_type; > @@ -1720,6 +1721,7 @@ int of_add_memory(struct device_node *node, bool dump) > > return 0; > } > +#endif This will break MIPS support. MIPS has it's own implementation of of_add_memory_bank (see ./arch/mips/boot/dtb.c), so in MIPS case the Kconfig options means "I have my own version of of_add_memory_bank" I currently don't know a good way out of this situation. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox