Re: [PATCH 1/2] spi: i.MX: Simplify cspi_0_0_init()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 10, 2014 at 08:23:41PM +0400, Alexander Shiyan wrote:
> Use SPI module software reset to simplify cspi_0_0_init().
> 
> Signed-off-by: Alexander Shiyan <shc_work@xxxxxxx>

Applied, thanks

Sascha

> ---
>  drivers/spi/imx_spi.c | 12 +++++-------
>  1 file changed, 5 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/spi/imx_spi.c b/drivers/spi/imx_spi.c
> index 45461bd..3c1ba61 100644
> --- a/drivers/spi/imx_spi.c
> +++ b/drivers/spi/imx_spi.c
> @@ -67,6 +67,8 @@
>  
>  #define CSPI_0_0_TEST_LBC		(1 << 14)
>  
> +#define CSPI_0_0_RESET_START		(1 << 0)
> +
>  #define CSPI_0_7_RXDATA			0x00
>  #define CSPI_0_7_TXDATA			0x04
>  #define CSPI_0_7_CTRL			0x08
> @@ -197,13 +199,9 @@ static void cspi_0_0_init(struct imx_spi *imx)
>  {
>  	void __iomem *base = imx->regs;
>  
> -	writel(CSPI_0_0_CTRL_ENABLE | CSPI_0_0_CTRL_MASTER,
> -		     base + CSPI_0_0_CTRL);
> -	writel(CSPI_0_0_PERIOD_32KHZ,
> -		     base + CSPI_0_0_PERIOD);
> -	while (readl(base + CSPI_0_0_INT) & CSPI_0_0_STAT_RR)
> -		readl(base + CSPI_0_0_RXDATA);
> -	writel(0, base + CSPI_0_0_INT);
> +	writel(CSPI_0_0_RESET_START, base + CSPI_0_0_RESET);
> +	do {
> +	} while (readl(base + CSPI_0_0_RESET) & CSPI_0_0_RESET_START);
>  }
>  
>  static unsigned int cspi_0_7_xchg_single(struct imx_spi *imx, unsigned int data)
> -- 
> 1.8.3.2
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox




[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux