Since commit a162dfe50345d3461010759f8a0e79f7e388c140 the ifup command is implemented in C and runs up to two external scripts.
If one of these scripts return with an error code, the command terminates silently. This can confuse a user because there is
no hint about the reason why it fails. Add error messages to avoid this case.
Signed-off-by: Juergen Borleis <jbe@xxxxxxxxxxxxxx>
---
net/ifup.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/net/ifup.c b/net/ifup.c
index 7b63136..c74120c 100644
--- a/net/ifup.c
+++ b/net/ifup.c
@@ -70,14 +70,18 @@ int ifup(const char *name, unsigned flags)
cmd_discover = asprintf("/env/network/%s-discover", name);
ret = run_command(cmd);
- if (ret)
+ if (ret) {
+ pr_err("Running '%s' fails\n", cmd);
goto out;
+ }
ret = stat(cmd_discover, &s);
if (!ret) {
ret = run_command(cmd_discover);
- if (ret)
+ if (ret) {
+ pr_err("Running '%s' fails\n", cmd);
goto out;
+ }
}
dev = get_device_by_name(name);
--
1.9.1
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
