On Mon, Mar 10, 2014 at 08:51:12AM +0100, Eric Bénard wrote: > Hi Sascha, > > Le Mon, 10 Mar 2014 08:09:57 +0100, > Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> a écrit : > > > On Fri, Mar 07, 2014 at 11:39:57AM +0100, Eric Bénard wrote: > > > this allows SATA to work on i.MX53 QSB-R : > > > barebox@Freescale i.MX53 Quick Start-R Board:/ ata0.probe=1 > > > imx-sata 10000000.sata: port 0: SATA link ok > > > imx-sata 10000000.sata: port 0: Spinning up device... > > > imx-sata 10000000.sata: port 0: ok. > > > ata0: registered /dev/ata0 > > > > > > before this fix the log was : > > > barebox@Freescale i.MX53 Quick Start-R Board:/ ata0.probe=1 > > > imx-sata 10000000.sata: port 0: SATA link timeout > > > set parameter: Connection timed out > > > > > > Signed-off-by: Eric Bénard <eric@xxxxxxxxxx> > > > --- > > > drivers/ata/sata-imx.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/ata/sata-imx.c b/drivers/ata/sata-imx.c > > > index b7bd110..450cf4f 100644 > > > --- a/drivers/ata/sata-imx.c > > > +++ b/drivers/ata/sata-imx.c > > > @@ -59,7 +59,7 @@ static int imx53_sata_init(struct imx_ahci *imx_ahci) > > > */ > > > val = readl(base + 0x180c); > > > val &= (0x3 << 1); > > > - val |= (0x1 << 1); > > > + val |= (0x2 << 1); > > > writel(val, base + 0x180c); > > > > I haven't applied this yet. Have you tested this on the regular (not -R) > > variant of the board? If not I'd like to do that before applying. > > I can try to test on an original QSB (with Dialog PMIC) but I don't see > why that would change as the difference between QSB and QSB-R is the > PMIC (Dialog to Freescale) and here we only change the clock source of > the SATA which has nothing to see with the PMIC. Yeah, you're probably right. I just wonder why we explicitly used the external clock in the first place and if there's a reason to make this configurable. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
