On 02/25/2014 11:51 PM, Uwe Kleine-König wrote:
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> --- arch/arm/boards/a9m2410/a9m2410.c | 23 +++++++++++++++++------ 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/arch/arm/boards/a9m2410/a9m2410.c b/arch/arm/boards/a9m2410/a9m2410.c index b2b6c87117a3..8d528cf60378 100644 --- a/arch/arm/boards/a9m2410/a9m2410.c +++ b/arch/arm/boards/a9m2410/a9m2410.c @@ -117,13 +117,24 @@ static int a9m2410_devices_init(void) 16, IORESOURCE_MEM, NULL); #ifdef CONFIG_NAND - /* ----------- add some vital partitions -------- */ - devfs_add_partition("nand0", 0x00000, 0x40000, DEVFS_PARTITION_FIXED, "self_raw"); - dev_add_bb_dev("self_raw", "self0"); - - devfs_add_partition("nand0", 0x40000, 0x20000, DEVFS_PARTITION_FIXED, "env_raw"); - dev_add_bb_dev("env_raw", "env0"); + devfs_create_partitions("nand0", (struct devfs_partition[]){
nit: It would be even more readable, if you move the struct devfs_partition[] out of a9m2410_device_init() and reference it here instead, i.e. static struct devfs_partition a9m2410_nand_partitions[] = { ... { } }; ... static int a9m2410_devices_init(void) { ... #ifdef CONFIG_NAND devfs_create_partitions("nand0", a9m2410_nand_partitions); #endif ... in here and the following patches. Sebastian
+ { + .offset = 0, + .size = 0x40000, + .flags = DEVFS_PARTITION_FIXED, + .name = "self_raw", + .bbname = "self0", + }, { + .offset = DEVFS_PARTITION_APPEND, + .size = 0x20000, + .flags = DEVFS_PARTITION_FIXED, + .name = "env_raw", + .bbname = "env0", + }, { + /* sentinel (detected by .name = NULL) */ + }}); #endif + armlinux_set_architecture(MACH_TYPE_A9M2410); return 0;
_______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox