Re: [PATCH 3/6] ARM: mvebu: introduce multi image support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/13/13 09:26, Sascha Hauer wrote:
Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
---
  arch/arm/boards/solidrun-cubox/Makefile     |  1 +
  arch/arm/boards/solidrun-cubox/lowlevel.c   | 37 +++++++++++++++++++++++++++++
  arch/arm/configs/solidrun_cubox_defconfig   |  6 ++++-
  arch/arm/dts/Makefile                       |  1 +
  arch/arm/mach-mvebu/Kconfig                 |  1 +
  arch/arm/mach-mvebu/Makefile                |  2 +-
  arch/arm/mach-mvebu/common.c                |  4 ++--
  arch/arm/mach-mvebu/include/mach/lowlevel.h |  2 +-
  arch/arm/mach-mvebu/lowlevel.c              |  2 +-
  images/.gitignore                           |  2 ++
  images/Makefile                             |  4 +++-
  images/Makefile.mvebu                       | 26 ++++++++++++++++++++
  scripts/Makefile.lib                        |  3 +++
  13 files changed, 84 insertions(+), 7 deletions(-)
  create mode 100644 arch/arm/boards/solidrun-cubox/lowlevel.c
  create mode 100644 images/Makefile.mvebu
[...]
diff --git a/arch/arm/boards/solidrun-cubox/lowlevel.c b/arch/arm/boards/solidrun-cubox/lowlevel.c
new file mode 100644
index 0000000..fdf5a7e
--- /dev/null
+++ b/arch/arm/boards/solidrun-cubox/lowlevel.c
@@ -0,0 +1,37 @@
[...]
+ENTRY_FUNCTION(start_solidrun_cubox)(void)
+{
+	uint32_t fdt;
+
+	__barebox_arm_head();
+
+	arm_cpu_lowlevel_init();
+
+	fdt = (uint32_t)__dtb_dove_cubox_start - get_runtime_offset();
+
+	mvebu_barebox_entry(fdt);
+}
[...]
> diff --git a/arch/arm/mach-mvebu/lowlevel.c b/arch/arm/mach-mvebu/lowlevel.c
> index 3f64c4a..11810cc 100644
> --- a/arch/arm/mach-mvebu/lowlevel.c
> +++ b/arch/arm/mach-mvebu/lowlevel.c
> @@ -24,5 +24,5 @@
>   void __naked barebox_arm_reset_vector(void)
>   {
>   	arm_cpu_lowlevel_init();
> -	mvebu_barebox_entry();
> +	mvebu_barebox_entry(0);
>   }

Sascha,

thanks for the patch set, I'll give it a go soon.

I understand that this is just a first step, but you are adding extra
lowlevel init to boards/solidrun-cubox/lowlevel.c but in the end it
should be part of mach-mvebu/lowlevel.c instead?

I have a some MVEBU boards with Dove and Armada 370 available and
could extend the patches to have a single lowlevel init again.

Sebastian


_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux