On 07/09/2013 07:38 PM, Sascha Hauer wrote:
On Fri, Jul 05, 2013 at 11:22:17PM +0200, Sebastian Hesselbarth wrote:
This RFC presents a working SDHCI driver for the IP found on Marvell
Dove SoCs.
@Sascha: We talked about refactoring common SDHCI code and I just want
to show what I came up with for Dove. After thinking about existing barebox
SDHCI, I had the impression that I should reimplement Dove SDHCI with writel
as it is already made in other SDHCI drivers.
Yes, common register accessors would make it possible to share code.
Maybe we can start with some sdhc_write[bwl]/read[bwl] functions which
are static inline wrappers around regular writel/readl. This would make
it possible to add an indirection there should we have to.
Sascha,
a quick look at the SDHCI spec showed that the "native" word width is
16b. At least Dove allows you to read registers at any width, but there
may be other controllers with limited word width capabilities. Anyway,
I guess we should try to have the common code and the defines use those
16b reg width.
I will be not checking mails regularily nor working on Barebox for the next
two weeks, so feel free to simply ignore the RFC. But I thought it will be
a good way to discuss your plans for common SDHCI code.
I think the driver looks mostly good. It should be a good base to factor
out common code in the future.
Ok, when I get back to this, I will prepare a real patch for it.
Sebastian
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
