On Tue, Dec 11, 2012 at 08:17:42PM +0100, Wolfram Sang wrote: > > > In barebox we have the strtoull_suffix function. We normally accept 'G', > > 'M' and 'k' suffixes. Restricting the ubi functions to '*iB' suffixes > > might be confusing for barebox users. Not accepting '*iB' suffixes might > > be confusing to UBI tool users. How about extending strtoull_suffix to > > accept '*iB' suffixes and use it here? It seems the all that's missing > > is to adjust *endp to skip the additional 'iB' > > OK. It probably makes sense to move the ubiutils_print_bytes() function > then to misc.c also and completely get rif of ubiutils-common? What > would be a proper name for the function, printull_suffix? Or > ulltostr_suffix? :) Both seem fine. BTW we already have size_human_readable() Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
