On 14:26 Thu 22 Nov , 张忠山 wrote: > In message <20121122061438.GR8327@xxxxxxxxxxxxxxxxx> Jean-Christophe PLAGNIOL-VILLARD wrote: > > On 14:01 Thu 22 Nov , 张忠山 wrote: > > > Signed-off-by: 张忠山 <zzs213@xxxxxxx> > > > --- > > > drivers/nor/cfi_flash_amd.c | 7 +++++-- > > > 1 files changed, 5 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/nor/cfi_flash_amd.c b/drivers/nor/cfi_flash_amd.c > > > index 45c59b9..3ab4be0 100644 > > > --- a/drivers/nor/cfi_flash_amd.c > > > +++ b/drivers/nor/cfi_flash_amd.c > > > @@ -62,8 +62,11 @@ static void amd_read_jedec_ids (struct flash_info *info) > > > udelay(1000); /* some flash are slow to respond */ > > > > > > info->manufacturer_id = jedec_read_mfr(info); > > > - info->device_id = flash_read_uchar (info, > > > - FLASH_OFFSET_DEVICE_ID); > > > + if(info->chipwidth == FLASH_CFI_BY16) > > > + info->device_id = flash_read16(flash_make_addr(info, 0, FLASH_OFFSET_DEVICE_ID)); > > > + else > > > + info->device_id = flash_read_uchar (info, > > > + FLASH_OFFSET_DEVICE_ID); > > > > make this global with all with support > > as don in linux > > > > as this is valid for amd and intel and st > > > Does this mean cp this code to the function > drivers/nor/cfi_flash_intel.c:intel_read_jedec_ids() ? you can not as the reset is flash depedent just factorise teh device_id read Best Regards, J. _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
