On Sun, Nov 18, 2012 at 01:31:06PM -0500, Robert P. J. Day wrote: > > there is one more oddity(?) with the way the linker "lds" files are > set up. if i read this correctly (and i could be wrong), here's > arch/x86/lib/barebox.lds.S: > > #undef i386 > #include <asm-generic/barebox.lds.h> > > which gets us to that included file, which contains: > > #if defined CONFIG_ARCH_IMX25 || \ > defined CONFIG_ARCH_IMX35 || \ > defined CONFIG_ARCH_IMX51 || \ > defined CONFIG_ARCH_IMX53 || \ > defined CONFIG_ARCH_IMX6 || \ > defined CONFIG_X86 || \ <-- that will be true, correct? > defined CONFIG_ARCH_EP93XX > #include <mach/barebox.lds.h> > #endif Instead of having this the users should include asm/barebox.lds.h which then in turn includes asm-generic/barebox.lds.h. > > which finally takes us to > arch/x86/mach-i386/include/mach/barebox.lds.h, which is nothing more > than a collection of macro definitions. there's no "pre-image" > content to be incorporated into the final image -- it's just > preprocessor content. so why isn't all that simply at the beginning > of the main x86 barebox.lds.S file? I don't know. It should probably be moved there. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
