On Tue, Oct 09, 2012 at 11:39:24AM +0400, Antony Pavlov wrote:
> On 9 October 2012 00:47, Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> wrote:
> > Hi Antony,
> >
> > On Mon, Oct 08, 2012 at 12:17:33AM +0400, Antony Pavlov wrote:
> >> This command is based on "mii-diag" and "mii-tool" programs.
> >>
> >> TODO:
> >> * drop MII_ANER_ and MII_AN_, use linux/mii.h macros;
> >> * add routines to manipulate media-independent interface state.
> >
> > Such a tool is nice to have. Some small comments inline.
> >
> ...
> >> +
> >> +/* Table of known MII's */
> >> +static struct {
> >> + u_short id1, id2;
> >> + u_short mask1, mask2;
> >> + char *name;
> >> +} mii_id[] = {
> >> + { 0x7810, 0x0003, 0xffff, 0xffff, "Level One LXT970A" },
> >> + { 0x7810, 0x0000, 0xffff, 0xfff0, "Level One LXT970/LXT971" },
> >> + { 0x0013, 0x78e0, 0xffff, 0xfff0, "Level One LXT971A" },
> >> +};
> >
> > Maybe we should find a place where other code (phylib?) can use this
> > table aswell?
>
> I agree. It is very convinient to use only one place to store the MII
> tranceivers database.
> But just now we have only one phy driver ("Generic PHY"). It has no
> table of know MII.
> I have tryed to port drivers/net/phy/lxt.c from linux. But there is no
> reason to do it: it contain only generic support for LXT970/971.
>
> IMHO mii_id[] table is a __temporary__ but a good-enough solution.
Ack
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
