Re: [PATCH 06/11] omap4: add support for booting an omap4 from usb.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Oct 06, 2012 at 12:33:08AM +0200, vj wrote:
> 
> Signed-off-by: vj <vicencb@xxxxxxxxx>

[...]

>  
>  /*
>   *  The following several lines are taken from U-Boot to support
> @@ -457,6 +458,21 @@ static int watchdog_init(void)
>  }
>  late_initcall(watchdog_init);
>  
> +#ifdef CONFIG_OMAP4_USBBOOT
> +static int omap4_usbboot_init(void)
> +{
> +	omap4_usbboot_open();
> +	omap4_usbboot_puts("USB communications initialized\n");
> +	return 0;
> +}
> +core_initcall(omap4_usbboot_init);
> +#else

I remember a hunk in a previous patch which detects whether we actually
are booting from USB. We could protect the code above with a
if (booting_from_usb) instead of deciding it at compile time.


> +/*
> + * omap4 usbboot interfaces with the omap4 ROM to reuse the USB port
> + * used for booting.
> + * The ROM code uses interrupts for the transfers, so do not modify the
> + * interrupt vectors.
> + */
>  static int omap_vector_init(void)
>  {

same here.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox


[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux