On Wed, Sep 26, 2012 at 12:59:48AM +0200, vj wrote: > --- > arch/arm/lib/armlinux.c | 2 +- > drivers/mci/omap_hsmmc.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/lib/armlinux.c b/arch/arm/lib/armlinux.c > index 191274e..74d59a9 100644 > --- a/arch/arm/lib/armlinux.c > +++ b/arch/arm/lib/armlinux.c > @@ -80,7 +80,7 @@ void armlinux_set_revision(unsigned int rev) > #ifdef CONFIG_ENVIRONMENT_VARIABLES > export_env_ull("armlinux_system_rev", rev); > #else > - return armlinux_system_rev; > + armlinux_system_rev = rev; > #endif > } > > diff --git a/drivers/mci/omap_hsmmc.c b/drivers/mci/omap_hsmmc.c > index e0b245b..e6f4e47 100644 > --- a/drivers/mci/omap_hsmmc.c > +++ b/drivers/mci/omap_hsmmc.c > @@ -238,7 +238,7 @@ static int mmc_init_setup(struct mci_host *mci, struct device_d *dev) > start = get_time_ns(); > while ((readl(&mmc_base->sysstatus) & RESETDONE) == 0) { > if (is_timeout(start, SECOND)) { > - dev_dbg(hsmmc->dev, "timedout waiting for cc2!\n"); > + dev_dbg(hsmmc->dev, "timeout waiting for reset done\n"); > return -ETIMEDOUT; > } > } This looks good, but it should be two patches. Please always give the subject the context of the patches, that would be "ARM: ..." for the first one and "mmc omap: ..." Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox